Tsmarvin/enable windows arm64#2267
Tsmarvin/enable windows arm64#2267jasonnorman66994-dot wants to merge 5 commits intoPowerShell:mainfrom
Conversation
- Remove unnecessary extra word in extension comment
…atic. Fixes crash on windows arm64.
Signed-off-by: jasonnorman66994-dot <jasonnorman66994@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request makes several small improvements to the PowerShell Editor Services codebase, including development environment configuration, API method signature changes, and documentation corrections. The PR title references "enable windows arm64" but the changes appear to be preparatory or supporting changes rather than direct ARM64 enablement.
Changes:
- Added VS Code extension recommendation for Azure development
- Changed
LoadAssemblyInPsesLoadContextfrom static to instance method to allow future extensibility - Fixed grammar in documentation comment for
ToStringSafeextension method
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.vscode/extensions.json |
Adds recommendation for the Azure Account VS Code extension to standardize development environment |
.gitignore |
Adds .vs/ directory to ignore Visual Studio metadata files |
src/PowerShellEditorServices/Utility/Extensions.cs |
Improves clarity of the summary comment for SafeToString extension method by fixing line break placement |
src/PowerShellEditorServices/Extensions/Api/EditorExtensionServiceProvider.cs |
Changes LoadAssemblyInPsesLoadContext from static to instance method with CA1822 suppression for future extensibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@andyleejordan, @daviwil, and @rjmholt, could you please review this PR? Your insights would be valuable. |
|
Hi, sorry no, there's a mix of changes in here and the only real change is making a core function non-static, without an explanation of why that "fixes" your Windows Arm64 issue (nor any explanation of how to repro that, as I've built and run on Arm64 Windows just fine). |
This pull request introduces a recommended VS Code extension for Azure development, updates the method signature for assembly loading to be non-static, and improves documentation clarity in the utility extensions. The most significant changes are grouped below:
Development Environment Improvements:
.vscode/extensions.jsonto recommend thems-vscode.azure-accountextension for VS Code users, helping standardize the development environment.Code Quality and API Changes:
LoadAssemblyInPsesLoadContextinEditorExtensionServiceProvider.csfrom a static to an instance method, suppressing the CA1822 warning to allow for future extensibility.Documentation and Comment Updates:
ToStringSafeextension method inExtensions.csfor improved readability and accuracy.PR Summary
PR Context